simple sorting programm for Linux

submitted by

https://github.com/metw0/qsort

wrote CLI in C++ to sort files. it’s very simple, just download and use. if you a photographer, video editor or just need to sort some files, you welcome (link in post)

19
6
1

Log in to comment

Hot Top New Old

I looked at your code and I can’t see anything that this does that I can’t already do with standard shell utils. Looks like a nice project for your learning but not something anyone else should use.

 reply
7
OP

yeah, I just wanted to share a school project

 reply
4
OP

oh, btw you seem to know your stuff… maybe I should make a CLI runner for bash/python scripts ? I think it would be a useful little tool, wouldn’t it ?

 reply
1

I don’t know what you mean by CLI runner. What would it do?

 reply
1
OP

oh, sorry I didn’t explain. To put it as simply as possible - I have all kinds of little bash scripts and a few python ones. It’s a real hassle to run them manually, so I decided to make a simple CLI to make this task easier. Something like that, I guess

 reply
1

sorry I guess I’m not following. Can you give an example of how using your tool to run scripts would be different than running them manually? It be great if you can show what a command line session would actually look like.

 reply
2
OP

nvm, I’m going to do it either way. you can check it (when I finish), if you want ))

 reply
0

You mean like a shell alias?

alias scriptname=long_shitty_command

 reply
2

1970s Unix command line tools: Are we a joke to you?

 reply
11

Sort how?

 reply
5
OP

all info in repo

 reply
0

Comments in Programming@programming.dev

I don’t think it is at all clear what this does.

It sorts files how?

 reply
10

It doesn’t sort them in the programming sense, it’s just moving files to another directory based on the filename 

qsort -w /home/user/Documents -t ext --df .txt

is equivalent to 

ls *.txt | xargs -I {} mv {} /home/user/Documents
 reply
4

Btw, you should not pipe ls. It’s unsafe.

 reply
2

ls can be piped safely if you use --zero:

ls --zero *.txt | xargs --null -I {} mv {} /home/user/Documents

While the above is a pretty silly example, one reason why you might want to do this is that xargs has a -P/--max-procs argument, that runs N commands in parallel. So you could do something like the following to gzip four files in parallel:

ls --zero *.txt | xargs --null -n1 -P4 gzip

This is a bit simpler than using the equivalent

find . -maxdepth 1 -name '*.txt' -print0 | xargs --null -n1 -P4 gzip
 reply
5

Source? I tried searching for it and found nothing.

 reply
4

I think the other user meant that ls output is not supposed to be treated as parsable, because the tool doesn’t offer any guarantees in that regards.

Shells have built-in support for globbing files anyway. xargs is also not needed. If someone is allergic to using a shell for loop, find always had -exec with ; instead + which wouldn’t trip on too many arguments.

 reply
5
OP

this is just a practice project, I shared it just so other people could take a look. you can see how it sorts files by checking out the repository

 reply
2
edited

Here are a few random thoughts based on skimming the source:

  • I’d advice againsts using -Weverything. Many of the warnings it enables are not very useful, and you are going to get a lot of them. And if you enable warnings, then fix them, or you’ll just miss it when your changes cause new warnings.
  • A couple of your check functions may reach the end of the function without returning, if type is not on of the expected values. That is undefined behavior. One simple way to avoid this, is to move the common return out of the ifs.
  • That const std::string type argument in the above functions should be enums, since you are just checking againts one of three fixed values ("name", "ext", and "date").
  • Speaking of which, I can’t think of any situation where you’d want to have an const std::string argument. Either use a const reference (const std::string&) or a string_view (const std::string_view). The latter has the advantage that it doesn’t create a new std::string if you call the function with a C-string and it can be sliced cheaply.
  • You have const std::string &df = df_str; in a couple of places, where df_str is a std::string passed by value. That is of course utterly pointless, and you should simply change df_str to be passed by const reference or as a string view.
  • You define main with an int return type, but use std::exit to exit the function. Those std::exit calls could all be replaced with return, which does the same thing in main.
  • Don’t do work before you need the results. For example, in check_type you perform two checks (saved as starts_with_dot and has_dash), that are not used if name == "name".
  • Nobody who sees a function named check_exists would expect it to create a directory, so it should be renamed to something more descriptive. It is also redundant, since you already check that the directory exists in main.cpp via is_directory, but unlike that check check_exists doesn’t actually verify that the path is a directory.
  • is_founded is Engrish
 reply
3
Insert image